Fix an inspector crash
authorMatthias Clasen <mclasen@redhat.com>
Thu, 7 May 2020 02:25:51 +0000 (22:25 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Thu, 7 May 2020 02:25:51 +0000 (22:25 -0400)
Fix the listmodel semantics of the controller model,
by making get_item return a reference.
This was broken in 4b9e5304cc.

gtk/gtkwidget.c

index b6beceb8bc99cbb633d09a09c9c07b9c8522815e..167d9a15ab7f3b66446a6fe4d13f492036e8b022 100644 (file)
@@ -11783,13 +11783,6 @@ gtk_widget_controller_list_get_prev (gpointer item,
   return NULL;
 }
 
-static gpointer
-gtk_widget_controller_list_get_item (gpointer item,
-                                     gpointer widget)
-{
-  return item;
-}
-
 /**
  * gtk_widget_observe_controllers:
  * @widget: a #GtkWidget
@@ -11821,7 +11814,7 @@ gtk_widget_observe_controllers (GtkWidget *widget)
                                                       gtk_widget_controller_list_get_next,
                                                       gtk_widget_controller_list_get_prev,
                                                       NULL,
-                                                      gtk_widget_controller_list_get_item,
+                                                      (gpointer) g_object_ref,
                                                       widget,
                                                       gtk_widget_controller_observer_destroyed);